From 48a1f9215bb5dedc314bcf788731a7dbdcb01f73 Mon Sep 17 00:00:00 2001 From: Richard Zampieri Date: Sat, 27 Apr 2024 16:52:44 -0700 Subject: [PATCH 1/2] feat: update template with expresso/core and inversify --- .eslintrc.cjs | 65 +++++++++++++++++++++++++-------------------------- package.json | 9 +++---- src/index.ts | 2 ++ tsconfig.json | 22 +++++------------ 4 files changed, 45 insertions(+), 53 deletions(-) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 35598cf..371b281 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -1,35 +1,34 @@ /* eslint-env node */ module.exports = { - extends: [ - "eslint:recommended", - "plugin:@typescript-eslint/recommended", - "eslint-config-prettier", - "prettier", - ], - parser: "@typescript-eslint/parser", - parserOptions: { - project: ["./tsconfig.cjs.json", "./tsconfig.esm.json","./tsconfig.json"], - }, - plugins: ["@typescript-eslint"], - root: true, - env: { - node: true, - jest: true, - }, - ignorePatterns: [ - "lib", - "node_modules", - ".eslintrc.cjs", - "**/__tests__/*.spec.ts", - "vitest.config.ts", - ], - rules: { - "@typescript-eslint/adjacent-overload-signatures": "error", - "@typescript-eslint/array-type": ["error", { default: "generic" }], - "@typescript-eslint/await-thenable": "error", - "@typescript-eslint/ban-types": "error", - "@typescript-eslint/class-literal-property-style": "error", - "@typescript-eslint/explicit-function-return-type": "error", - }, - }; - \ No newline at end of file + extends: [ + "eslint:recommended", + "plugin:@typescript-eslint/recommended", + "eslint-config-prettier", + "prettier", + ], + parser: "@typescript-eslint/parser", + parserOptions: { + project: ["./tsconfig.cjs.json", "./tsconfig.esm.json", "./tsconfig.json"], + }, + plugins: ["@typescript-eslint"], + root: true, + env: { + node: true, + jest: true, + }, + ignorePatterns: [ + "lib", + "node_modules", + ".eslintrc.cjs", + "**/__tests__/*.spec.ts", + "vitest.config.ts", + ], + rules: { + "@typescript-eslint/adjacent-overload-signatures": "error", + "@typescript-eslint/array-type": ["error", { default: "generic" }], + "@typescript-eslint/await-thenable": "error", + "@typescript-eslint/ban-types": "error", + "@typescript-eslint/class-literal-property-style": "error", + "@typescript-eslint/explicit-function-return-type": "error", + }, +}; diff --git a/package.json b/package.json index 82f3ebc..5806794 100644 --- a/package.json +++ b/package.json @@ -1,8 +1,8 @@ { - "name": "@expressots/package-name", + "name": "@expressots/resend-provider", "version": "0.0.1", - "description": "Expressots - modern, fast, lightweight nodejs web framework (@package-name)", - "author": "", + "description": "Expressots - Email using Resend Provider (@expressots/resend-provider)", + "author": "Richard Zampieri", "main": "./lib/cjs/index.js", "types": "./lib/cjs/types/index.d.ts", "exports": { @@ -67,13 +67,14 @@ "lint:fix": "eslint \"src/**/*.ts\" --fix" }, "dependencies": { + "@expressots/core": "latest", + "inversify": "6.0.2", "reflect-metadata": "0.2.2" }, "devDependencies": { "@codecov/vite-plugin": "0.0.1-beta.6", "@commitlint/cli": "18.0.0", "@commitlint/config-conventional": "17.7.0", - "@expressots/core": "latest", "@release-it/conventional-changelog": "7.0.1", "@types/node": "20.4.9", "@typescript-eslint/eslint-plugin": "6.6.0", diff --git a/src/index.ts b/src/index.ts index e69de29..54fd63d 100644 --- a/src/index.ts +++ b/src/index.ts @@ -0,0 +1,2 @@ +/* export your provider here */ +//export * from "./your-provider"; diff --git a/tsconfig.json b/tsconfig.json index 5d75c9b..54f9203 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "strict": true, "esModuleInterop": true, - "forceConsistentCasingInFileNames":true, + "forceConsistentCasingInFileNames": true, "skipLibCheck": true, "strictNullChecks": false, "checkJs": true, @@ -12,18 +12,8 @@ "allowSyntheticDefaultImports": true, "experimentalDecorators": true, "emitDecoratorMetadata": true, - "types": [ - "node", - "reflect-metadata", - "vitest/globals" - ], -}, - "include": [ - "src/**/*.ts" - ], - "exclude": [ - "node_modules", - "**/__tests__/*.spec.ts", - "scripts/**/*", - ] -} \ No newline at end of file + "types": ["node", "reflect-metadata", "vitest/globals"] + }, + "include": ["src/**/*.ts"], + "exclude": ["node_modules", "**/__tests__/*.spec.ts", "scripts/**/*"] +} From bd1838a1bf57f0a4b8cef4b2fb693d2e91087aa1 Mon Sep 17 00:00:00 2001 From: Richard Zampieri Date: Sat, 27 Apr 2024 16:58:50 -0700 Subject: [PATCH 2/2] feat: update pr template --- .github/PULL_REQUEST_TEMPLATE.md | 37 +++++++++++++++++--------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 62f55e1..1a32be3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,13 +2,19 @@ Our guidelines for submitting a pull request. -## Before submitting a Pull Request, please make sure you have verified the following: +## Before submitting your PR, please verify the following: - [ ] The commit message follows our guidelines: - - A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity. - - We use Microverse's commit message convention - - The convention stablish that a commit message has to be in the present tense, imperative and lowercase. - - Example: `fix typo in README.md` + + > Make sure you prefix your commit message with the type of change you are making. Your commit message should look like this: `type: description of the change`. + > + > - Fixing a bug : `fix: description of the change`. + > - Adding a new feature : `feat: description of the change`. + +See the options for the different types of changes you can make in the `package.json` file of your project. + +**Leave the options below unchecked if they are not applicable to your Pull Request.** + - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) @@ -17,31 +23,28 @@ Our guidelines for submitting a pull request. What kind of change does this PR introduce? + - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes +- [ ] Documentation content changes +- [ ] Test - [ ] Other... Please describe: -## What is the current behavior? - -Please describe the current behavior that you are modifying, or link to a relevant issue. - -Issue Number: N/A - -## What is the new behavior? - -Describe the new behavior or link to a relevant issue. - ## Does this PR introduce a breaking change? - [ ] Yes - [ ] No -If this PR contains a breaking change, please describe the impact and migration path for existing applications below. +If `yes` Please describe the impact and mitigation strategy for existing applications. + +## What was changed? + +Please describe what you have changed in this PR. ## Other information -Any other information that is important to this PR. \ No newline at end of file +Any other information that is important to this PR.