Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] Action key > Lock Image on click > right click not as reliable #1487

Open
cannibalox opened this issue Dec 3, 2024 · 2 comments · May be fixed by #1489
Open

[regression] Action key > Lock Image on click > right click not as reliable #1487

cannibalox opened this issue Dec 3, 2024 · 2 comments · May be fixed by #1489
Labels

Comments

@cannibalox
Copy link

cannibalox commented Dec 3, 2024

Describe the bug
in recent builds, when the settings advanced > Action key > Lock Image on click is set to right click :
sometimes the right click menu will appear preventing the lock image behavior.
at other times it will work, but then once the image is locked, the right click doesn't trigger the contextual menu anymore.

To Reproduce
set ``advanced > Action key > Lock Image on click > right click`, then hover images, right click. sometimes it will fail. if it works, try to enable the right click menu : it doesn't appear

Expected behavior
in previous builds (I believe before commit #1472), it was working flawlessly :
. RMB would lock the image without the contextual menu appearing
. once image is locked, a new RMB would trigger the context menu so we can interact with the locked image

right click to lock image is the default in Imagus, and it's useful for keyboardless browsing. Access to the right click menu is important to use addons like web clippers, image annotation, etc...

Desktop (please complete the following information):

  • win11 23h2
  • chromium 131
  • H+ Version 1.0.223
@extesy extesy added the bug label Dec 3, 2024
@extesy
Copy link
Owner

extesy commented Dec 3, 2024

@LiliaDoe this looks like one of your recent changes

@LiliaDoe
Copy link
Contributor

LiliaDoe commented Dec 5, 2024

I have a new pr coming which will fix this. Just haven't fully tested it. It will activate after holding the button briefly, and the pr will add back the ability to set it to a click again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants