Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse click action key for right/middle mouse button #1489

Draft
wants to merge 61 commits into
base: master
Choose a base branch
from
Draft

Add mouse click action key for right/middle mouse button #1489

wants to merge 61 commits into from

Conversation

LiliaDoe
Copy link
Contributor

@LiliaDoe LiliaDoe commented Dec 5, 2024 •
edited
Loading

I've tested a majority of the action keys with right click and middle click. Lock works as it did before. If using both click and hold on right click, it's possible to still pull up the context menu on a zoomed image, depending on which action keys are set to right click.

@LiliaDoe
Make action keys only show up on certain actions
944ca15
@LiliaDoe
Update key values
916ee2a
@LiliaDoe
Add add variable for right or middle key code to separate tap and hold
d31a842
@LiliaDoe
Update key handlers
42eea4b
@LiliaDoe
Fix middle click's long press affecting right click's activation time
0fe67a3
@LiliaDoe
Fix switch case
fc187aa
@LiliaDoe
Add handling if tap and hold are both for the same button
9be4336
@LiliaDoe
Add handling of both tap and hold enabled for same button
571d3e0
@LiliaDoe
Add functionality of mouse button clicks
552bf65
@LiliaDoe
Update context menu comment
12916ac
@LiliaDoe
Fix right and middle MouseActionKey not setting correctly
f567af7
@LiliaDoe
Rework both tap and hold for single mouse button signal
65ceaed
@LiliaDoe
Rework action key handler into switch case for clarity and compactness
0f6f219
@LiliaDoe
Add handler to popup
1c5ab0f
@LiliaDoe
Fix mouseAction.bind not working
527ddbd
@LiliaDoe
Update action key selectors
00fbbfd
@LiliaDoe
Renable context menu when not using action key on image
0984c66
@LiliaDoe
Add return false or return true back to action key functions
0cb2ee3
@LiliaDoe
cancelSourceLoading with close key if imgFullSize is true
569fe68
@LiliaDoe
Merge branch 'extesy:master' into master
77e4122
@LiliaDoe
Remove unnecessary breaks
02742f4
@LiliaDoe
Move mouse button switch case to restoreOptions()
0ea6c82
@LiliaDoe
Remove mouse button switch case from saveOptions()
67ad88b
@LiliaDoe
Remove extra lines
2039193
@LiliaDoe
Clarify action key name
174644b
@LiliaDoe
Merge branch 'master' into Add-click-actionkey-for-right/middle-mouse…
2fb86fc 
…-button
@LiliaDoe
Clarify short click handler
3950240
@LiliaDoe
Fix long presses always triggering on mouse release
b018a00
@LiliaDoe
fix short clicks not working if they aren't paired with long clicks o…
26e7dcb 
…n the same button
@LiliaDoe
format fix
db07a1f
LiliaDoe added 10 commits December 5, 2024 18:52
@LiliaDoe
Copy link
Contributor Author

LiliaDoe commented Dec 7, 2024

Everything looks correct, and what I have tested runs as expected. Performance seems fine from what I've tested. If any bugs or performance issues are found though, let me know and I'll work on fixing them~

@LiliaDoe LiliaDoe marked this pull request as ready for review December 7, 2024 01:55
extesy
extesy reviewed Dec 7, 2024
View reviewed changes
js/hoverzoom.js Outdated
// create right and middle button timers to handle them separately
let longRightPressTimer;
let longMiddlePressTimer;
// TODO: Prevent middle click from triggering when it's an action key
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still TODO or is this comment a leftover from the early development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's something that is todo, but I couldn't figure it out yet

@LiliaDoe LiliaDoe marked this pull request as draft December 7, 2024 23:02
LiliaDoe added 15 commits December 7, 2024 23:21
@LiliaDoe
Prevent default middle click behavior when used to activate action key
4fb1ca9
@LiliaDoe
Fix $(this).mousemove(); not firing with mouse action keys
fc61c8f
@LiliaDoe
fix mousemove() not triggering
81cda73
@LiliaDoe
fix context menu not showing
3b33af4
@LiliaDoe
Move auxclick eventListener to mouseaction so it only gets added when…
da10330 
… a click action key is selected
@LiliaDoe
Fix actionKeys triggering incorrectly if both hold and click are sele…
8bd646a 
…cted
@LiliaDoe
Remove redundant text
f9363de
@LiliaDoe
Update hoverzoom.js
810a048
@LiliaDoe
Add option to change time required for hold action
3932405
@LiliaDoe
Combine variables to reduce clutter
4758bfe
@LiliaDoe
Fix accidental triggers on release if both click and hold are used
878b90b
@LiliaDoe
Change default and range
387b115
@LiliaDoe
Separate preventDefault variable so the buttons won't affect eachother
829024e
@LiliaDoe
Organize functions to be closer to where they are relevant
86b8a02
@LiliaDoe
Merge branch 'extesy:master' into Add-instant-activate-for-right/midd…
b68efe5 
…le-mouse-button
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extesy extesy extesy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@LiliaDoe @extesy