From d86c44632b20bf73bb592d457b715c9edcc58c22 Mon Sep 17 00:00:00 2001 From: Scott Dutton Date: Tue, 18 Dec 2018 23:16:38 +0000 Subject: [PATCH] Add some more type hints --- src/Loaders/Checkstyle.php | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/Loaders/Checkstyle.php b/src/Loaders/Checkstyle.php index 9281a58..ad8773a 100644 --- a/src/Loaders/Checkstyle.php +++ b/src/Loaders/Checkstyle.php @@ -76,11 +76,7 @@ public static function getDescription(): string return 'Parses a report in checkstyle format'; } - /** - * @param XMLReader $reader - * @param string $currentFile - */ - protected function handleErrors($reader, $currentFile) + protected function handleErrors(XMLReader $reader, string $currentFile) { if ($reader->name === "error") { $this->coveredLines @@ -90,12 +86,7 @@ protected function handleErrors($reader, $currentFile) } } - /** - * @param XMLReader $reader - * @param string $currentFile - * @return string - */ - protected function handleFile($reader, $currentFile) + protected function handleFile(XMLReader $reader, string $currentFile): string { if (( $reader->name === "file" &&