Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using JUCE_APPLICATION_NAME_STRING and TARGET_PROPERTY in template CMake files #16

Open
glynternet opened this issue Nov 22, 2022 · 2 comments

Comments

@glynternet
Copy link

Hi @eyalamirmusic,

Thanks so much for these templates. I've been searching around in the CMake docs for how to understand setting the target property of JUCE_PROJECT_NAME so that it's used in getApplicationName but I've not quite been able to work it out still; at least partially because I'm not that familiar with Cmake still.

How is this meant to be used?

References:

JUCE_APPLICATION_NAME_STRING="$<TARGET_PROPERTY:${TargetName},JUCE_PROJECT_NAME>"

const String getApplicationName() override { return JUCE_APPLICATION_NAME_STRING; }

@Vlsarro
Copy link

Vlsarro commented Oct 3, 2023

Hello. A couple of thoughts on the subject.

"$<TARGET_PROPERTY:${TargetName},JUCE_PROJECT_NAME>" is meant to get JUCE_PROJECT_NAMEproperty of your JUCE application target but there is no such property.

JUCE_PROJECT_NAME should be changed to JUCE_PRODUCT_NAME in my opinion. So correct version would look like this:

 JUCE_APPLICATION_NAME_STRING="$<TARGET_PROPERTY:${TargetName},JUCE_PRODUCT_NAME>" 

I can be wrong but it stems from these JUCE cmake functions:

@eyalamirmusic
Copy link
Owner

You are correct, that's a bug, I will fix that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants