Take more launch-config-related sizes as size_t #684
Assignees
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Sep 22, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
eyalroz
added a commit
that referenced
this issue
Sep 22, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
eyalroz
added a commit
that referenced
this issue
Sep 23, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
|
Windows doesn't like our use of std::limits, seems like :-( |
eyalroz
added a commit
that referenced
this issue
Sep 23, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
eyalroz
added a commit
that referenced
this issue
Sep 23, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
eyalroz
added a commit
that referenced
this issue
Oct 26, 2024
…unch config builder, and checking them ourselves (using more extensive checks to boot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our launch config methods for setting block size or grid size in blocks, which take a single value - take the "correct" type:
grid::dimension_torgrid::block_dimension_t. That's a problem, since users may provide a value exceeding the type's representation range and get a silent narrowing conversion. Instead, let's takesize_t's, and check them ourselves - especially against the type representation limitations, but also against the rest of the limits we're already aware of at that stage.The text was updated successfully, but these errors were encountered: