Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect custom selector syntax in documentation #27

Open
Cam opened this issue Nov 14, 2019 · 1 comment
Open

Incorrect custom selector syntax in documentation #27

Cam opened this issue Nov 14, 2019 · 1 comment

Comments

@Cam
Copy link

Cam commented Nov 14, 2019

In the documentation you have the following as an example for the custom selector. However the package adds the . for the classname itself.

Marquee3k.init({
    selector: '.selector-name', // define a custom classname
});

Arguably the package could be changed to allow for both classes and IDs by removing the .. Changing the documentation to the following would be a good start.

Marquee3k.init({
    selector: 'selector-name', // define a custom classname without the '.'
});
@ezekielaquino
Copy link
Owner

Thanks for the report @Cam – will have a look at this to accommodate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants