Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse is not working #29

Open
MathiasGmeiner opened this issue Feb 27, 2020 · 5 comments
Open

Reverse is not working #29

MathiasGmeiner opened this issue Feb 27, 2020 · 5 comments

Comments

@MathiasGmeiner
Copy link

I had to change this line 88 to

const direction = this.reverse == 'true' ? -1 : 1;

@ghost
Copy link

ghost commented Mar 31, 2020

Wait, this does not solve the issue. It moves backward, but only once. After that it's blank.

@chrisallick
Copy link

Was never able to get that option working. But if you just go to line 27 in marquee3k.js and hard code it: this.reverse = false; at least it will reverse.

@fritzlaszlo
Copy link

a quick "workaround" for this bug:
the dataset itself already triggers the direction change. no matter if its true or false.
see here the original codepen without dataset:
https://codepen.io/ezekielaquino/pen/jwOMqV
see here with reverse dataset:
https://codepen.io/flweb/pen/xxOjrLR

@brdavs
Copy link

brdavs commented Oct 17, 2022

This is great, but the minified version does not contain the fix.

@dollseb
Copy link

dollseb commented May 9, 2023

The min.js still does not contain the fix. Movement is always reversed. Changing the dataset has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants