Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean CodeBase and Comments #1

Open
uaktags opened this issue Jun 4, 2013 · 4 comments
Open

Clean CodeBase and Comments #1

uaktags opened this issue Jun 4, 2013 · 4 comments

Comments

@uaktags
Copy link
Collaborator

uaktags commented Jun 4, 2013

Alot of code is sloppy, thanks to me, thanks to others, now's the chance to clean it.
Comments have been left out in alot of places, standardize their appearance and add them
Decide on a coding-style...stick to it.

@ferdis
Copy link
Contributor

ferdis commented Jun 4, 2013

This is funny.

I might just have a go with it. What coding style are you using here?

@uaktags
Copy link
Collaborator Author

uaktags commented Jun 4, 2013

I haven't really started looking into it yet. I'll probably just go with what was originally there, I just know I mix and match different conventions all the time. I'll probably stick with PEAR or K&R (one of the variants of). To be frank, in the end, i'll probably end up taking all the main php files and throwing them into a PHP Style Formater and letting it clean it up. But comments are widely missed and/or invalid after years of alteration. That definitely needs fixing.

@ferdis
Copy link
Contributor

ferdis commented Jun 4, 2013

Let's agree to not use formatter. 😃

I'll fork the repo and add comments where they are due, I'm also going to use K&R to style things that aren't.

@uaktags
Copy link
Collaborator Author

uaktags commented Jun 5, 2013

Okay, I suppose I can agree to it. Thanks, I'll start this little clean up either tonight or tomorrow!

uaktags added a commit that referenced this issue Jul 13, 2013
uaktags pushed a commit that referenced this issue Jul 30, 2013
minor bug at include footer.tpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants