Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings needs expansion #36

Open
uaktags opened this issue Jul 20, 2016 · 2 comments
Open

Settings needs expansion #36

uaktags opened this issue Jul 20, 2016 · 2 comments

Comments

@uaktags
Copy link
Collaborator

uaktags commented Jul 20, 2016

The engine is missing alot of configuration opportunities and holds onto too many hardcoded aspects. Obviously a Settings class will have to be created and initialized directly after the DBEngine, because it needs access to get all the settings, then pass it onto every Module and Hook before they spin up.

@deohnas
Copy link
Contributor

deohnas commented Oct 8, 2016

The settings structure are kinda confusing. With groupings and actual settings value being in the same table.

How about having 2 tables:

setting_groups
settings

@deohnas
Copy link
Contributor

deohnas commented Oct 8, 2016

I would even argue for having configuration stored in plain PHP array files. Easier to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants