Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss: update type/help_text when changed? #34

Open
benzkji opened this issue Feb 6, 2018 · 0 comments
Open

discuss: update type/help_text when changed? #34

benzkji opened this issue Feb 6, 2018 · 0 comments

Comments

@benzkji
Copy link
Contributor

benzkji commented Feb 6, 2018

as for now, type remains the same as when the textblock is first inserted into the database. this might not always be the desired behaviour (my help_text patch updates the help text, if it was empty in the database), but automatically updating can also be strange (two blocks with the same key, but different help text, edge case, but still...).

possible solution could be

  • always update
  • update when a kwarg is passed (ie update=True)
  • never update (current state)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant