Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phone_number_field different between PersonalInformation and DGFIP scopes #10

Open
giffarda opened this issue Nov 7, 2022 · 2 comments
Assignees

Comments

@giffarda
Copy link

giffarda commented Nov 7, 2022

"phone_number_field": {
"type": "object",
"properties": {
"value": {
"type": "string",

"mobile": {
"type": "boolean",
"$comment": "if the telephone is mobile, meaning it can receive SMS"
},

Hi,

For phone number field type, a boolean "mobile" was added. It is indicated in the DGFIP schema.json but not in PersonalInformation schema.json. Can you confirm we want this boolean in all scopes which need a phone number ?

Thanks in advance

@jthiard jthiard self-assigned this Nov 9, 2022
@jthiard
Copy link
Collaborator

jthiard commented Nov 9, 2022

There seems to be a mismatch between the json schemas and the markdown documentation for that matter.

To move this forward I suggest that we add this mobile property in all places where a phone number is expected, but that we make this property optional (it is required in the DGFIP scope at the moment).

Does this will fit your use case ?

@giffarda
Copy link
Author

giffarda commented Nov 9, 2022

Yes, it is good for us. In my opinion, the important thing is that the phone number type is the same in all over the specification, as much as possible.
The property mobile can be required or optional, but optional seems to be a right choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants