You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
For the new Retail Portal, we will introduce shared components (header, sidenavbar) and independently from our approach, this leads to an issue with the current fabric scss library. As the header will load parts of fabric, and will be "a container" for the integrated application, initially we need scoped styling for each application + shared components.
This is currently not possible as some Atoms are styling directly DOM Tags instead of abstracting them to CSS-Classes. More Details regarding "Rules of Play" will be shared (internally).
As part of this one might start also thinking of introducing Accessibility features as part of new major release.
Task
Rewrite the following Atoms, so that they are not styling DOM Tags directly but based on Class names:
Atoms/Toggle -> Radio and Checkbox Styling
Atoms/Button.scss
Atoms/Forms.scss
Molecules/Tables.scss
Additionally, it would be quite helpful when we could have already a fabric.css production ready file created in the repo so we can easily use with a CDN (or use https://rawgit.com/ ).
Outcome
A new version of Fabric as this is definitely breaking applications and should be a major version bump.
This would allow existing applications to update to the newer version when they are ready. This would also mean that we need to discuss topics around bug fixes, as master would be referencing to this new v2 and v1 would exist in a separate branch.
The text was updated successfully, but these errors were encountered:
Problem
For the new Retail Portal, we will introduce shared components (header, sidenavbar) and independently from our approach, this leads to an issue with the current fabric scss library. As the header will load parts of fabric, and will be "a container" for the integrated application, initially we need scoped styling for each application + shared components.
This is currently not possible as some Atoms are styling directly DOM Tags instead of abstracting them to CSS-Classes. More Details regarding "Rules of Play" will be shared (internally).
As part of this one might start also thinking of introducing Accessibility features as part of new major release.
Task
Rewrite the following Atoms, so that they are not styling DOM Tags directly but based on Class names:
Additionally, it would be quite helpful when we could have already a fabric.css production ready file created in the repo so we can easily use with a CDN (or use https://rawgit.com/ ).
Outcome
A new version of Fabric as this is definitely breaking applications and should be a major version bump.
This would allow existing applications to update to the newer version when they are ready. This would also mean that we need to discuss topics around bug fixes, as master would be referencing to this new v2 and v1 would exist in a separate branch.
The text was updated successfully, but these errors were encountered: