New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best not to use index as key #15

Open

ZooeyMiller opened this issue May 25, 2018 · 0 comments

Assignees

ZooeyMiller commented May 25, 2018

here you use the index as a key

HP-game/src/components/whackAMole/whackAMole.js

Line 74 in 6236bf6

key={i}

You shouldn't use indices as keys in react as it messes with the diffing.

Kent C Dodds explains it better than I can: https://egghead.io/lessons/react-use-the-key-prop-when-rendering-a-list-with-react

(ping me on gitter if you need the fac egghead login)

iPhatty self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment