Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love it! #65

Open
helenzhou6 opened this issue Apr 13, 2018 · 0 comments
Open

Love it! #65

helenzhou6 opened this issue Apr 13, 2018 · 0 comments

Comments

@helenzhou6
Copy link

helenzhou6 commented Apr 13, 2018

Hey! Great job guys 😍

  • Love how you have error handling from the server side -> and how you have handled it in the callback! We hadto use cookies which was 😱
  • Well done for doing tests and everything passing (and good coverage too):

screen shot 2018-04-13 at 10 22 01

  • README is awesome (though just needs updating on some of the instructions on how to initiate everything
  • You can see your username on each page! Awesome
  • Great modularisation of your code - I like how you have a new file for each database query
  • Use of promises! 😱😍
  • Did you get linting to work for the whole team? Can you teach us please! Thanks ^^
  • I also like how you have different pages (where some are protected etc) - we ran into problems with displaying errors since we always would always re-locate back to '/'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant