Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Classes #44

Open
eadehemingway opened this issue Mar 2, 2018 · 2 comments
Open

Empty Classes #44

eadehemingway opened this issue Mar 2, 2018 · 2 comments
Assignees
@haydnba @helenzhou6
Labels
duplicate This issue or pull request already exists

Comments

@eadehemingway
Copy link

Seem to be lots of empty classes in css for example line 112, 116, 140 that could be gotten rid of?
Also lots of empty ID's that seem not to be doing anything (e.g line 128, 129)
@helenzhou6
Copy link
Collaborator

(NB Same issue raised in #42 )

@helenzhou6 helenzhou6 mentioned this issue Mar 2, 2018
Open
@Parissai Parissai added the duplicate This issue or pull request already exists label Mar 2, 2018
@helenzhou6
Copy link
Collaborator

Side Note: Look at media queries (need to have it so that when layout changes to mobile view, the hamburger should appear at the same time)

LawEKS added a commit that referenced this issue Mar 2, 2018
@LawEKS
Clean up CSS code
3e667e6 
Relates #44
@LawEKS LawEKS mentioned this issue Mar 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydnba haydnba

@helenzhou6 helenzhou6

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haydnba @helenzhou6 @Parissai @eadehemingway