Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking your request methods #39

Open
maxgerber opened this issue Apr 13, 2018 · 0 comments
Open

Checking your request methods #39

maxgerber opened this issue Apr 13, 2018 · 0 comments
Labels

Comments

@maxgerber
Copy link

I might be UTTERLY wrong here and if so feel free to ignore me but I don't see anywhere in your server where you're specifying which method each handler is being used for. In our servers we often use the same endpoints to perform completely different functions depending on if its a GET or POST request. I see that you guys aren't doing that but I think its a good idea to make sure that your requests will only fire given the right method (you can check this on req.method)

Also you guys will <3 express week where this stuff becomes a hell of a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants