Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might be better to apply a class to the body #28

Open
VirtualDOMinic opened this issue Jul 20, 2018 · 1 comment
Open

Might be better to apply a class to the body #28

VirtualDOMinic opened this issue Jul 20, 2018 · 1 comment
Labels

Comments

@VirtualDOMinic
Copy link

I noticed you seem to directly apply a style to the body to change the background colour. I feel like I've heard that it's best practice to apply CSS classes to the HTML elements and have all the actual styling in the CSS file. Would probably neaten up your js as well (avoiding use of rgba in a big object in there)

@sbinlondon
Copy link
Collaborator

Can you add a class to the body tag??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants