Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase is πŸ‘¨β€πŸ³ πŸ˜— #75

Open
ko-karol opened this issue Mar 14, 2023 · 0 comments
Open

Codebase is πŸ‘¨β€πŸ³ πŸ˜— #75

ko-karol opened this issue Mar 14, 2023 · 0 comments

Comments

@ko-karol
Copy link

Impressive how you managed to keep it tidy like it is! A few tips:

  • There are some inconsistencies in how functions are exported, some are exported inline and some at the bottom of the file.
  • There are some inconsistencies in how functions are declared; some are arrow functions, and some are regular functions.
  • Instead of naming your pages explore-stuff/reflect-stuff, might be a better idea to create explore/reflect folders so instead of

https://week7-9-artbadge.vercel.app/explore-main

you'd have

https://week7-9-artbadge.vercel.app/explore/main

  • next.config is still .cjs hahaha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant