Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphonso's nittpicking #67

Open
camelPhonso opened this issue Jun 21, 2023 · 0 comments
Open

Alphonso's nittpicking #67

camelPhonso opened this issue Jun 21, 2023 · 0 comments

Comments

@camelPhonso
Copy link

The site looks really neat!!!

I noticed this one pattern that happens a few times:

setBirdcage((prevCage) => {
      return prevCage.map((b) =>
        b.id === bird.id ? { ...b, quantity: b.quantity - 1 } : b
      );
    });

This is a silly issue to add, BUT:

  • love the ternary, nice one;
  • naming the mapped bird as 'b' got confusing to my tired out brain. I do actually think sometimes being more descriptive is preferable, like:
setBirdcage((prevCage) => {
     return prevCage.map((cagedBird) =>
       cagedBird.id === bird.id ? { ...b, quantity: cagedBird.quantity - 1 } : cagedBird
     );
   });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant