Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

BUG: List items disappear when they contain a link #169

Open
Jab11n opened this issue Jun 5, 2024 · 4 comments · May be fixed by #170
Open

BUG: List items disappear when they contain a link #169

Jab11n opened this issue Jun 5, 2024 · 4 comments · May be fixed by #170
Labels
bug Something isn't working

Comments

@Jab11n
Copy link

Jab11n commented Jun 5, 2024

Whenever I visit a page on Napture that has a link inside of a list element, all of the text within the list element disappears.
For example, if this is in the body of the HTML:

<ol>
    <li><a href="buss://blog.root">blog.root</a> - my personal mini-blog, notebook style</li>
</ol>

the whole list item will just be blank.

To Reproduce

  1. Go to any page that has links in a list (i used jabin.it and wiki.fr)
  2. Look at the list and realize items with links are just blank.

Expected behavior
The link to look normal

Screenshots
image
image

Environment

  • OS: Windows 11
  • Napture 1.2.2 (I recently cloned and compiled Napture from source)

EDIT: I don't think the actual version is 1.2.2, that's just what it says. I used the latest from the GitHub, not the releases tab.

@Jab11n Jab11n added the bug Something isn't working label Jun 5, 2024
@GStudiosX2
Copy link
Contributor

GStudiosX2 commented Jun 5, 2024

This is normal li's only accept text nodes also for version you could probably put the commit id

@Jab11n
Copy link
Author

Jab11n commented Jun 5, 2024

I believe it's commit 6acdf7d

@GStudiosX2
Copy link
Contributor

Added support in my fork https://github.com/GStudiosX2/webx probably gonna pr soon

@Jab11n
Copy link
Author

Jab11n commented Jun 5, 2024

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants