-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate concept of rewiring config as an alternative of ejecting or forking react-scripts #4970
Comments
See reply in timarney/react-app-rewired#162 (comment). Thanks! Once a consensus is met, a proposal issue with most-common use cases would be great! |
@Timer Though I regret that this issue got closed that fast. May I kindly ask to reopen this issue and see if it's of interest for the community at all? |
I feel that this is a conversation best had in timarney/react-app-rewired#162 because that's where the community's home is. We really want to accommodate the 90% use cases. At current time, we can say pretty confidently that this decision of not adding rewiring is "set in stone"; we can probably revisit this in about a year, give or take. Thank you for bringing this to our attention! |
I see, you have already made a firm decision in this regard. Actually I would love to have this conversation here, inside the official repo. |
This is definitely something that's important. Ejecting seems like such an unnecessary thing when its so easy to add in a 'rewire' hook into react-scripts - if FB wanted to do it. |
Is this a bug report?
(write your answer here)
No
First thank you for this awesome master piece, I really appreciate that work.
Though would like to ask you to incorporate the concept of rewiring config as promoted in:
https://github.com/timarney/react-app-rewired
(Unfortunately it's not maintained anymore)
For details please see here:
https://github.com/timarney/react-app-rewired#how-to-rewire-your-create-react-app-project
This way it would be super easy to add custom loaders for SASS, TypeScript, Inline SVGs, etc.
Related #99
The text was updated successfully, but these errors were encountered: