Skip to content

Commit

Permalink
Fix Pascal Name Parsing Issue with Numbers
Browse files Browse the repository at this point in the history
Summary: In Graph API v20, two words are introduced P2MInvoicePayments and WithAsset3D - causing the logic of parsing pascal name to fail and generate 'M' and 'D' as individual words. This caused the endpoint name parsing fail at last.

Reviewed By: yoongyj, liliarizona

Differential Revision: D61582281

fbshipit-source-id: 4b1cf3f966f433cf1c2a7fa4641ca8048857a0f5
  • Loading branch information
stcheng authored and facebook-github-bot committed Aug 21, 2024
1 parent cf2befe commit b73190c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module FacebookAds
# on github and we'll fix in our codegen framework. We'll not be able to accept
# pull request for this class.

class AdAccountOptimizationGoalsAeMv2Eligibility < AdObject
class AdAccountOptimizationGoalsAemv2Eligibility < AdObject
OPTIMIZATION_GOAL = [
"AD_RECALL_LIFT",
"APP_INSTALLS",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module FacebookAds
# on github and we'll fix in our codegen framework. We'll not be able to accept
# pull request for this class.

class P2MInvoicePayments < AdObject
class P2mInvoicePayments < AdObject

field :page_id, 'string'
field :payments, { list: 'object' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module FacebookAds
# on github and we'll fix in our codegen framework. We'll not be able to accept
# pull request for this class.

class WithAsset3D < AdObject
class WithAsset3d < AdObject

field :id, 'string'
has_no_post
Expand Down

0 comments on commit b73190c

Please sign in to comment.