Field specified more than once

[apa512]

Which SDK version are you using?

0.8.0.0

What's the issue?

Many different operations lead to an object with some kind of messed up state.

Steps/Sample code to reproduce the issue

ad = FacebookAds::Ad.get("123", session)
ad.status = "ACTIVE"
ad.save
ad.status

Observed Results:

FacebookAds::ClientError (Syntax error "Field status specified more than once. This is only possible before version 2.1" at character 34: id,configured_status,status,status:  (fbtrace_id: hidden))

Expected Results:

I expect to see "ACTIVE".

Any idea what I'm doing wrong?

[ericzou]

same issue here for attribution_spec. looks like adset.__all_fields contains both symbol and strings for the same key after save.. e.g. #<Set: {:id, :attribution_spec, :name, "attribution_spec"}>

[ericzou]

dug a bit more. it seems that the following line is converting the symbol to string.

      def define_writer(name)
        define_method("#{name}=") do |val|
          changes[name] = val
          @__all_fields.add(name.to_s) <--- 
        end
      end

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

[peylun]

👋 Any update on this issue?
I am encountering the same error when trying to save values on different level objects. Oddly even though it returns error on save, the value managed to get persisted; occasionally it manages to save successfully, but accessing the value after reload! returns the same error.

Examples

• Updating adset.name (no error on save; error on adset.name after saving)
  

• Updating adset.targeting (error on save and adset.targeting after saving)
  

• Similar errors on ad.creative update & save, capaign.daily_budget update & save

[itsmeurbi]

This issue persists. As @ericzou pointed out, the problem lies in the define_writter method
Here's an example of what I'm doing:

session = FacebookAds::Session.new(access_token: 'token', app_secret: 'secret')
facebook_ad_campaign = FacebookAds::Campaign.get('id', session)
facebook_ad_campaign.daily_budget
facebook_ad_campaign.daily_budget = 100
facebook_ad_campaign.save

When executing facebook_ad_campaign.daily_budget, the daily_budget field is added to @__all_fields as a symbol.
Then, assigning facebook_ad_campaign.daily_budget = 100 adds daily_budget to @__all_fields as a string.

At some point, the library includes both versions of daily_budget in the request, leading to an error. I can easily replicate this issue in the Graph API Explorer by adding the same valid field multiple times to a request.