Fixed use of FBApplicationLaunchMode for FBDevice #648
Conversation
|
Hi @AndreasReich! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| } else { | ||
| return (FBFuture*)processIdQueryResult; | ||
| } |
There was a problem hiding this comment.
The final branch herer looks a little suspicious. If the app is running then we fail, but in all other conditions we should probably attempt to launch the app
There was a problem hiding this comment.
You're probably right but maybe we should still not launch it if the future state is cancelled?
There was a problem hiding this comment.
Actually you might be right and we should just propagate the cancel. @lawrencelomax I'm guessing cancelling will be so rare that either is fine
|
@AndreasReich thanks for working on idb! You'll need to accept the Facebook CLA before we can ship this PR |
|
Contacted my legal department already on helping me to fill out the company version of the CLA check before the holidays, just contacted them again to get this sorted :) |
Previously, the app would be restarted for FBApplicationLaunchModeForegroundIfRunning and not fail if already running for FBApplicationLaunchModeFailIfRunning.
AndreasReich
force-pushed
the
fix-fbdevice-launchmodes
branch
from
11851a8
to
aadaad9
Compare
|
@c-ryan747 it's been quite a while, but the CLA should be sorted out by now |
Motivation
Previously, an Application on a device would be restarted for FBApplicationLaunchModeForegroundIfRunning and not fail if already running for FBApplicationLaunchModeFailIfRunning.
Test Plan
Tested this manually with an application that calls directly into FBDeviceControl framework.
This application in turn has some automated tests that capture this behavior (this is how I found the issue).
I have not added any tests to idb, but will happily do so if someone can point me to it (I'm still new to the project).
Related PRs
n/a