From 0cbf9634b4baea4da56edef5214d19d213426be0 Mon Sep 17 00:00:00 2001 From: Crystal Jin Date: Wed, 23 Oct 2024 14:48:59 -0700 Subject: [PATCH] mvfstEnableFlowControlTimeBasedUpdates -> mvfstDisableFlowControlTimeBasedUpdates Summary: That way we can keep the default to false in the mc. This makes adding params to ios or other platforms easier Reviewed By: NishantNori Differential Revision: D64791939 fbshipit-source-id: 23cf0e7962619d4754a766537a5cb87e92a22487 --- quic/flowcontrol/QuicFlowController.cpp | 2 +- quic/state/TransportSettings.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/quic/flowcontrol/QuicFlowController.cpp b/quic/flowcontrol/QuicFlowController.cpp index 1d0da3a83..81fe77535 100644 --- a/quic/flowcontrol/QuicFlowController.cpp +++ b/quic/flowcontrol/QuicFlowController.cpp @@ -34,7 +34,7 @@ Optional calculateNewWindowUpdate( (updateTime - *lastSendTime) > transportSettings.flowControlRttFrequency * srtt; // If we are autotuning then frequent updates aren't required. - if (transportSettings.enableFlowControlTimeBasedUpdates && + if (!transportSettings.disableFlowControlTimeBasedUpdates && enoughTimeElapsed && !transportSettings.autotuneReceiveConnFlowControl) { return nextAdvertisedOffset; } diff --git a/quic/state/TransportSettings.h b/quic/state/TransportSettings.h index 3dfdb0279..d3d383cfb 100644 --- a/quic/state/TransportSettings.h +++ b/quic/state/TransportSettings.h @@ -398,7 +398,7 @@ struct TransportSettings { double ackTimerFactor{kAckTimerFactor}; // If flow control updates should be sent based on time passed since last // update. - bool enableFlowControlTimeBasedUpdates{true}; + bool disableFlowControlTimeBasedUpdates{false}; // Check if idle timer needs to be triggered manually. bool checkIdleTimerOnWrite{false}; // Whether to process callbacks per received packet.