From 631a22295c96af6257649722fef2597967d40a92 Mon Sep 17 00:00:00 2001 From: Joseph Beshay Date: Fri, 17 May 2024 15:02:35 -0700 Subject: [PATCH] Workaround gcc11 bug that occurs when building AckHandlersTest Summary: This fixes a compiler bug that is hit when building AckHandlersTest.cpp using gcc11. This was reported in https://github.com/facebook/mvfst/issues/331 and started happening consistently when the Github CI build was updated to use Ubuntu 22.04. Reviewed By: chadaustin, sharmafb Differential Revision: D57506683 fbshipit-source-id: a156a9ba7641f395ea9da01ec084fdccb3d6a88b --- quic/state/test/AckHandlersTest.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/quic/state/test/AckHandlersTest.cpp b/quic/state/test/AckHandlersTest.cpp index b352fdb8e..54a6e4bb4 100644 --- a/quic/state/test/AckHandlersTest.cpp +++ b/quic/state/test/AckHandlersTest.cpp @@ -1090,8 +1090,8 @@ TEST_P(AckHandlersTest, TestAckMultipleSequentialBlocksLoss) { conn.outstandings.packets.begin(), conn.outstandings.packets.end(), [](auto& op) { - return op.packet.header.getPacketSequenceNum() == 15 || - op.packet.header.getPacketSequenceNum() == 16; + auto seqno = op.packet.header.getPacketSequenceNum(); + return seqno == 15 || seqno == 16; }); EXPECT_TRUE(itr != conn.outstandings.packets.end()); EXPECT_TRUE(itr->declaredLost); @@ -1114,8 +1114,8 @@ TEST_P(AckHandlersTest, TestAckMultipleSequentialBlocksLoss) { conn.outstandings.packets.begin(), conn.outstandings.packets.end(), [](auto& op) { - return op.packet.header.getPacketSequenceNum() == 15 || - op.packet.header.getPacketSequenceNum() == 16; + auto seqno = op.packet.header.getPacketSequenceNum(); + return seqno == 15 || seqno == 16; }); EXPECT_TRUE(itr == conn.outstandings.packets.end());