Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in Python 2 + Python 3 with Travis/GitHub Action #35

Closed
cooperlees opened this issue Aug 3, 2018 · 4 comments
Closed

Test in Python 2 + Python 3 with Travis/GitHub Action #35

cooperlees opened this issue Aug 3, 2018 · 4 comments
Assignees
@cooperlees
Labels
enhancement

Comments

@cooperlees
Copy link
Contributor

Issue Description

  • Can we please have travis test Python aspects of OpenR in both Python 2 and Python 3.

Environment

In you Ubuntu travis environment should be enough

Minimal test code / Steps to reproduce the issue

  • No repro, just want to see things tested in both Python versions.

What's the actual result?

Travis showing that Python aspects pass in both versions or only Python 3 (as far as I am concerned 👍)

What's the expected result?

Python 3 first.
@saifhhasan
Copy link
Contributor

We will look into this as we are now fully supporting python3

@saifhhasan
Copy link
Contributor

It's been a while. Coming back to this again. Can you spare a cycle to help us setting this up ? Thanks :)

@cooperlees cooperlees self-assigned this Jul 17, 2020
@cooperlees
Copy link
Contributor Author

I'll make sure we have a GitHub action checking this.

@cooperlees cooperlees changed the title Test in Python 2 + Python 3 with Travis Test in Python 2 + Python 3 with Travis/GitHub Action Jul 17, 2020
@cooperlees
Copy link
Contributor Author

Will take care of this in #56

facebook-github-bot pushed a commit that referenced this issue May 7, 2021
@yi-xian @facebook-github-bot
(easy) Fix pyre error #56/#35/#11
5e38c6e 
Summary: Fix pyre error #56/#35/#11 in Open/R python codebase.

Reviewed By: saifhhasan

Differential Revision: D28271698

fbshipit-source-id: b21e5743f15bbdbaa030e7e8c1beac7ecea6e369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooperlees cooperlees

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saifhhasan @cooperlees