Fix background getting clipped when border-radius is set #47939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes facebook#47905 Border was disappearing when only one edge had an alpha of 0. This was due to clipping conditional Reviewed By: shwanton, NickGerleman Differential Revision: D66397736
Summary: Before we were clipping Android background drawable to the padding box. This is not how its done on web. The background should remain under the border so that if the border is traslucent you can see the background underneath Differential Revision: D66463305
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66463305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before we were clipping Android background drawable to the padding box. This is not how its done on web.
The background should remain under the border so that if the border is traslucent you can see the background underneath
Differential Revision: D66463305