Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(image): [android] react okhttp network fetcher cache control tests #47953

Conversation

mateoguzmana
Copy link
Contributor

Summary:

This is a follow up for the new cache control options for the Android Image component introduced in #47182, #47348 & #47426. And to make sure the cache control header works as expected and avoid missing the issue fixed in #47922, this PR introduces test cases to make sure this is getting applied as expected in the ReactOkHttpNetworkFetcher.

Changelog:

[INTERNAL] [ADDED] - ReactOkHttpNetworkFetcher cache control tests

Test Plan:

yarn test-android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2024
@mateoguzmana mateoguzmana marked this pull request as ready for review November 26, 2024 12:45
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 9, 2024
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in 37c532a.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 37c532a

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants