Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code style #56

Closed
wants to merge 330 commits into from
Closed

Update code style #56

wants to merge 330 commits into from

Conversation

iodic
Copy link
Collaborator

@iodic iodic commented Nov 5, 2024

This changeset is branched from the feature/test-events branch and it contains updates to the code style so that we conform to the WordPress coding standards.

@iodic iodic requested a review from vahidkay-meta November 5, 2024 14:54
@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

joran29 and others added 24 commits December 6, 2024 16:59
@joran29 @iodic
Update advanced edit toggle arrow
4c7b17f
@Luka130899 @iodic
Add custom_data validation in FacebookCapiEvent clas
1ef8920
@Luka130899 @iodic
Update nonce error message in send_capi_event endpoint
b759523
@Luka130899 @iodic
Update js ajax request error logic in sendTestEvent function
6de4c6b
@Luka130899 @iodic
Remove not used data from row element in events-log table
5173d7e
@Luka130899 @iodic
Update testEventName value for advanced payload to include all event …
a60d047 
…names from payload
@Luka130899 @iodic
Do not send custom_data data when an advanced payload is being sent
95a1154
@joran29 @iodic
Update event log error section style/behavior
57e0125
@joran29 @iodic
Move event log error message in a new td
9748bec
@joran29 @iodic
Update event log error section style/behavior
ac01eae
@joran29 @iodic
Update show error section style in event log block
4979494
@joran29 @iodic
Minor style update for show error section in event log block
54adff2
@joran29 @iodic
Minor style update for show error section in event log block
43c70a7
@Luka130899 @iodic
Update check for required advanced payload
9e326f8
@joran29 @iodic
Update test event table style
677593c
@Luka130899 @iodic
Use correct test_event_code when populating advanced payload field
0dc0224
@joran29 @iodic
Update populate advanced event with a default event code if one not p…
643c1d2 
…rovided
@joran29 @iodic
Add event hints section to events block when no events logged
250f62b
@joran29 @iodic
Minor style update for event hints
6d0bacd
@joran29 @iodic
Minor style update for event log block td
b6577c9
@joran29 @iodic
Update error pill colors
a9f0084
@joran29 @iodic
Update test/event hints style
9836291
@joran29 @iodic
Update test/event hints icons with symbols
020d8b2 
Update icons style
@joran29 @iodic
Minor style update for test/event hints symbols
e768593
@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@iodic has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vahidkay-meta merged this pull request in 2cd641c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vahidkay-meta vahidkay-meta vahidkay-meta approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iodic @facebook-github-bot @vahidkay-meta @joran29 @Luka130899 @nikolap994