NDK 27 & Support 16kb page size for Android15 #98
Conversation
|
Hi @brocollie08! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@brocollie08 could you rebase? The CI should be green now |
brocollie08
force-pushed
the
ndk27-android15-support
branch
from
354ba79 to
55b6dce
Compare
|
@brocollie08 has updated the pull request. You must reimport the pull request before landing. |
cortinico
changed the title
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @cortinico, thanks for the quick review, anything else needed before this can go in? |
Nope this needs to be reviewed internally and then can be merged. Can take a couple of days |
|
@cortinico merged this pull request in cdd876d. |
Motivation
#97
Summary
Updated ndk to 27, enabled flexible page size support
https://developer.android.com/guide/practices/page-sizes#compile-r27-higher
Test Plan
Built locally and checked alignment via test method here as well as
objdumpon the binary