Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #346 is incorrect #350

Open
maurimo opened this issue Jan 24, 2023 · 0 comments
Open

PR #346 is incorrect #350

maurimo opened this issue Jan 24, 2023 · 0 comments

Comments

@maurimo
Copy link

maurimo commented Jan 24, 2023

The PR #346 reorder two elements in a structure, whose meaning was actually to define "first structure + buffer at the end". Those fields cannot be reordered, but an alternative is allocating a unique buffer of the right size (#348)
desert-sailor added a commit to desert-sailor/gloo that referenced this issue Feb 15, 2023
@desert-sailor
Update linux.cc for issue facebookincubator#350
2af9c0a 
fix: PR facebookincubator#346 is incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurimo