Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make failed #389

Open
seunggihong opened this issue Oct 7, 2024 · 1 comment · May be fixed by #400
Open

Make failed #389

seunggihong opened this issue Oct 7, 2024 · 1 comment · May be fixed by #400

Comments

@seunggihong
Copy link

seunggihong commented Oct 7, 2024 •
edited
Loading

When i run to following command :

$ cmake ../ -DBUILD_BENCHMARK=1 -DUSE_CUDA=1 -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda -DUSE_NCCL=1 -DUSE_MPI=1 $ make

I have this issue.

[ 93%] Linking CXX executable benchmark
/usr/bin/ld: ../libgloo.a(file_store.cc.o): in function `gloo::rendezvous::FileStore::get(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
file_store.cc:(.text+0x1c22): undefined reference to `gloo::rendezvous::Store::kDefaultTimeout'
/usr/bin/ld: ../libgloo.a(file_store.cc.o): in function `gloo::rendezvous::FileStore::wait(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)':
file_store.cc:(.text._ZN4gloo10rendezvous9FileStore4waitERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EE[_ZN4gloo10rendezvous9FileStore4waitERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EE]+0xa): undefined reference to `gloo::rendezvous::Store::kDefaultTimeout'
/usr/bin/ld: ../libgloo.a(prefix_store.cc.o): in function `gloo::rendezvous::PrefixStore::wait(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)':
prefix_store.cc:(.text._ZN4gloo10rendezvous11PrefixStore4waitERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EE[_ZN4gloo10rendezvous11PrefixStore4waitERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EE]+0xa): undefined reference to `gloo::rendezvous::Store::kDefaultTimeout'
collect2: error: ld returned 1 exit status
make[2]: *** [gloo/benchmark/CMakeFiles/benchmark.dir/build.make:131: gloo/benchmark/benchmark] Error 1
make[1]: *** [CMakeFiles/Makefile2:258: gloo/benchmark/CMakeFiles/benchmark.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

How can i solve it?

Thanks.
@c-p-i-o
Copy link
Contributor

c-p-i-o commented Oct 31, 2024

Seems like the benchmark code is broken. We probably need to fix it up.

e-kwsm added a commit to e-kwsm/gloo that referenced this issue Dec 6, 2024
@e-kwsm
fix(benchmark): add definition of static constexpr member variable
c820fbb 
prior to C++17, definition is necessary
fix facebookincubator#389
@e-kwsm e-kwsm linked a pull request Dec 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(benchmark): add definition of static constexpr member variable e-kwsm/gloo
2 participants
@c-p-i-o @seunggihong