Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old content is usually on the left side in the diff format. #9

Closed
zzl0 opened this issue Jun 22, 2024 · 4 comments
Closed

Old content is usually on the left side in the diff format. #9

zzl0 opened this issue Jun 22, 2024 · 4 comments

Comments

@zzl0
Copy link
Contributor

zzl0 commented Jun 22, 2024 •
edited
Loading

Usually the old content (line number) of a diff is on the left side (the content is changing from left -> right)

scrut diff:

Screenshot 2024-06-22 at 11 36 00 AM

similar diff
@ukautz
Copy link
Contributor

ukautz commented Jun 26, 2024

That is very sensible. If you are willing, feel free to put up a PR (starting point here)? Otherwise I will get to it in the coming days.

@zzl0
Copy link
Contributor Author

zzl0 commented Jun 28, 2024

I can take a look at this some time next week. I will leave a comment here if I am working on it. If you have time before that, feel free to pick it up.

@zzl0
Copy link
Contributor Author

zzl0 commented Jul 7, 2024

@ukautz I submitted a diff stack internally for this.

facebook-github-bot pushed a commit that referenced this issue Jul 9, 2024
@zzl0 @facebook-github-bot
diff: make old content line number on the left side
48ec6f3 
Summary:
Usually the old content (line number) is on the left side (the content is changing from `left` -> `right`) in diff format.

Related issue: #9

Reviewed By: AndreasBackx

Differential Revision: D59424694

fbshipit-source-id: 02bc22ead16e6c414ffe3e8645bb443d310576b0
@zzl0
Copy link
Contributor Author

zzl0 commented Feb 2, 2025

Closing this issue as it was already fixed in 48ec6f3

@zzl0 zzl0 closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukautz @zzl0