Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RAII version of folly::init #7894

Closed
assignUser opened this issue Dec 5, 2023 · 2 comments
Closed

Use RAII version of folly::init #7894

assignUser opened this issue Dec 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@assignUser
Copy link
Collaborator

Description

folly::init was deprecated recently and now throws a warning. In many places the use was corrected in #7700 but it caused issues with the fuzzer tests (see PR).

@majetideepak
Copy link
Collaborator

folly::Init{&argc, &argv, true}; is causing the Init object to be destroyed immediately and not at the end of main. That is why we are seeing issues with benchmark and fuzzer.
Looking at the RAII folly change here facebook/folly@7bf1486#diff-fe24748541a4b73975e31bb08821bb15c783ecdd74e2057d256c4cd1b893ba92
folly::init(&argc, &argv); is deprecated and the RAII version is folly::Init init(&argc, &argv);
The latter does call the RAII API.

@assignUser
Copy link
Collaborator Author

assignUser commented Dec 7, 2023

Ah so the problem was me, sorry xD I'll add a fix

@assignUser assignUser linked a pull request Dec 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants