Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI adapters test #11038

Closed
wants to merge 2 commits into from
Closed

Fix CI adapters test #11038

wants to merge 2 commits into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Sep 19, 2024 •
edited
Loading

Minio download broke in this PR: #10920

Resolves: #11035

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit dfbc4d4
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66ec0bfef37fa600089944ef

@majetideepak majetideepak requested a review from kgpai September 19, 2024 11:33
pedroerp
pedroerp approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 48c6628.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 48c66281.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@majetideepak majetideepak deleted the fix-ci-adapters branch October 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroerp pedroerp pedroerp approved these changes

@kgpai kgpai Awaiting requested review from kgpai

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to find minio executable minio-2022-05-26'
3 participants
@majetideepak @facebook-github-bot @pedroerp