Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): Fix build metrics report #11839

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build(ci): Fix build metrics report #11839

wants to merge 5 commits into from

Conversation

assignUser
Copy link
Collaborator

Changes to finding GTest caused the build metrics job to fail as we don't have GTest in the image yet. See #11837

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a41d055
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/675b5b0853a02e000865b3ee

@assignUser assignUser mentioned this pull request Dec 12, 2024
Closed
@assignUser assignUser requested a review from kgpai December 12, 2024 05:16
kgpai
kgpai approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; will merge when the report succeeds and the comment is reverted 👍

@assignUser
Copy link
Collaborator Author

@kgpai I have removed the job level guard, this way we can test report generation from inter-repo PRs like this one. The generated report will be uploaded as an artifact as well.
I left the git push guard in place for PRs, as the report only has data from main, as that's how conbench works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai kgpai approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@assignUser @kgpai @facebook-github-bot