From b36647398988f9aa58b7d30b2cbcd27480bdc819 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 12 Dec 2024 05:04:15 +0100 Subject: [PATCH 1/5] don't force system deps --- .github/workflows/build-metrics.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index 2a3285e2f6ac..2cfb48047b54 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -47,10 +47,6 @@ jobs: defaults: run: shell: bash - env: - VELOX_DEPENDENCY_SOURCE: SYSTEM - simdjson_SOURCE: BUNDLED - xsimd_SOURCE: BUNDLED steps: - uses: actions/checkout@v4 with: From 22cb7b998636419823c99badb65055b1ac8eadc5 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 12 Dec 2024 19:16:50 +0100 Subject: [PATCH 2/5] revert - enable report upload --- .github/workflows/build-metrics.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index 2cfb48047b54..b5e4ea2206b2 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -117,7 +117,7 @@ jobs: "/tmp/metrics" upload-report: - if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }} + # if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }} permissions: contents: write runs-on: ubuntu-latest From 5b2a597563e72c1e84ec817dd3aed3fde81ce8cc Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 12 Dec 2024 22:48:05 +0100 Subject: [PATCH 3/5] remove job wide guard --- .github/workflows/build-metrics.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index b5e4ea2206b2..abf0bc786f87 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -117,7 +117,6 @@ jobs: "/tmp/metrics" upload-report: - # if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }} permissions: contents: write runs-on: ubuntu-latest From 826f78c4a333041618ed926457afff6f7dade24b Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 12 Dec 2024 22:48:23 +0100 Subject: [PATCH 4/5] upload rendered report as artifact --- .github/workflows/build-metrics.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index abf0bc786f87..a2201f2aa93b 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -151,6 +151,12 @@ jobs: cd scripts/bm-report nix-shell --run "quarto render report.qmd" + - name: Upload Report Artifact + uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3 + with: + name: report + path: scripts/bm-report/report.html + - name: Push Report # The report only uses conbench data from 'main' # so any data generated in a PR won't be included From a41d055891ff98e3ed28c076f76cc4118704e200 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 12 Dec 2024 22:52:02 +0100 Subject: [PATCH 5/5] limit artifact retention --- .github/workflows/build-metrics.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index a2201f2aa93b..4838da650c8d 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -156,6 +156,7 @@ jobs: with: name: report path: scripts/bm-report/report.html + retention-days: 5 - name: Push Report # The report only uses conbench data from 'main'