Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Fix build metrics report #11839

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build(ci): Fix build metrics report #11839

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b366473
don't force system deps
assignUser Dec 12, 2024
22cb7b9
revert - enable report upload
assignUser Dec 12, 2024
5b2a597
remove job wide guard
assignUser Dec 12, 2024
826f78c
upload rendered report as artifact
assignUser Dec 12, 2024
a41d055
limit artifact retention
assignUser Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/build-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ jobs:
defaults:
run:
shell: bash
env:
VELOX_DEPENDENCY_SOURCE: SYSTEM
simdjson_SOURCE: BUNDLED
xsimd_SOURCE: BUNDLED
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -121,7 +117,6 @@ jobs:
"/tmp/metrics"

upload-report:
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }}
permissions:
contents: write
runs-on: ubuntu-latest
Expand Down Expand Up @@ -156,6 +151,13 @@ jobs:
cd scripts/bm-report
nix-shell --run "quarto render report.qmd"

- name: Upload Report Artifact
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: report
path: scripts/bm-report/report.html
retention-days: 5

- name: Push Report
# The report only uses conbench data from 'main'
# so any data generated in a PR won't be included
Expand Down
Loading