feat: Make PartitionedOutput reclaimable #11856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
tanjialiang
force-pushed
the
po_spill
branch
from
43ad645 to
fc9d92b
Compare
tanjialiang
commented
Dec 17, 2024
| @@ -108,43 +108,8 @@ velox::memory::MemoryPool* DriverCtx::addOperatorPool( | |||
|
|
|||
| std::optional<common::SpillConfig> DriverCtx::makeSpillConfig( | |||
| int32_t operatorId) const { | |||
| const auto& queryConfig = task->queryCtx()->queryConfig(); | |||
There was a problem hiding this comment.
Another option would be to keep it here and lazy initialize the spill component of outputbuffer in partitioned output operator.
tanjialiang
force-pushed
the
po_spill
branch
2 times, most recently
from
1ab49e4 to
6ad2c82
Compare
tanjialiang
force-pushed
the
po_spill
branch
from
6ad2c82 to
dd92701
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
force-pushed
the
po_spill
branch
2 times, most recently
from
48fdbfc to
a0672ae
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
force-pushed
the
po_spill
branch
4 times, most recently
from
38d3924 to
65d5c88
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitioned output spill work as following:
As soon as partitioned output is triggered to reclaim from itself, this task's output buffer switches to spill mode, meaning:
Partitioned output spill currently only works for PARTITION mode. This PR has limitations of not efficiently save memory by spilling, due to unspilling using a considerably large amount of memory. But it lays a foundation for persistent shuffle. Future changes are coming, to make this spill more coordinated with other plan nodes' spill so that node memory usage is more efficient.