Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a running xp from one grid to another (e.g. when refactoring) cancels the XP #31

Open
louismartin opened this issue May 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@louismartin
Copy link
Contributor

I had a grid grid_a with too many experiments running so I refactored some of its experiments in a new grid file grid_b.
While running the new grid dora grid grid_b worked as expected and found the already running experiment, when I ran dora grid grid_a again it cancelled all the experiments that were now in grid_b.

It would be nice to have a way to track this scenario and only garbage collect experiments that are not linked to a grid.
And also it would be nice to ask the user for confirmation when cancelling experiments.

@louismartin louismartin added the bug Something isn't working label May 12, 2022
@adefossez
Copy link
Contributor

Yep, my take was that the marginal value of garbage collection compared to the complexity it adds to the code wasn't worth it. Keep in mind there is no real DB just files over NFS. If you have an easy and reasonably reliable solution I would be happy to take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants