We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The BigInt relational operators, for example BigInt::operator> are not optimal.
BigInt::operator>
Currently, the code is:
bool BigInt::operator>(const BigInt& num) const { return !((*this < num) or (*this == num)); }
This potentially makes two calls, one to operator< and another to operator ==. Only one call needs to be made:
operator<
operator ==
bool BigInt::operator>(const BigInt& num) const { return *this < num; }
The same issue with <=, where it takes just < to give the right results. Here is the corrected code:
<=
<
bool BigInt::operator<=(const BigInt& num) const { return !(num < *this); }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The BigInt relational operators, for example
BigInt::operator>
are not optimal.Currently, the code is:
This potentially makes two calls, one to
operator<
and another tooperator ==
. Only one call needs to be made:The same issue with
<=
, where it takes just<
to give the right results. Here is the corrected code:The text was updated successfully, but these errors were encountered: