Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is our standard convention for handling NaN values in data streams? #498

Open
drslebedev opened this issue Jan 17, 2025 · 0 comments
Open

Comments

@drslebedev
Copy link
Contributor

Description

Currently, there is no clear convention for handling NaN values in data streams within the gr4 project. This ambiguity could lead to inconsistent behavior across various blocks, resulting in errors or unexpected outcomes.

Some blocks may introduce NaN values due to invalid math calculations. We need to decide how NaN values should be handled. For example, ignored, propagated, or replaced. Note that there are also potential performance implications if multiple blocks must check for NaN.

Considerations

  • Do we allow blocks to publish NaN values, or should they filter them out?
  • What performance trade-offs are acceptable if every block checks for NaN?

Proposed Actions

  1. Establish a clear convention for the usage and interpretation of NaN values in data streams.
  2. Document the agreed-upon convention in the developer guidelines.
  3. Ensure all blocks implement the same approach to handling NaN values.
@github-project-automation github-project-automation bot moved this to 🆕 Ideas (∞) in Digitizer Reimplementation Jan 17, 2025
@drslebedev drslebedev moved this from 🆕 Ideas (∞) to 🔖 Selected (6) in Digitizer Reimplementation Jan 17, 2025
@drslebedev drslebedev moved this from 🔖 Selected (6) to 📋 Backlog in Digitizer Reimplementation Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant