Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falcoSchema.json should be generated by Falco itself #3149

Closed
leogr opened this issue Nov 24, 2023 · 9 comments · Fixed by #3313
Closed

falcoSchema.json should be generated by Falco itself #3149

leogr opened this issue Nov 24, 2023 · 9 comments · Fixed by #3313
Assignees
Milestone

Comments

@leogr
Copy link
Member

leogr commented Nov 24, 2023

Motivation

Falco should be responsible for defining its supported rule syntax schema. Other tools can consume the schema, then.

For projects like falco-project, consuming this schema in JSON format is very useful. The project is currently using a static version of it https://github.com/falcosecurity/falco-playground/blob/main/src/components/Editor/falcoSchema.json

Feature

Make Falco generate the rule syntax schema in JSON format.

Alternatives

Additional context

Initially, I've filled this issue under the falco-playground project since we have a live example of what we need. The end goal is to transfer this issue to the falco repository and implement the feature in Falco.

I'm assigning this issue to me, but I need volunteers to help. 🙏
/assign
/help

cc @falcosecurity/core-maintainers @falcosecurity/falco-playground-maintainers

@poiana
Copy link
Contributor

poiana commented Nov 24, 2023

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Motivation

Falco should be responsible for defining its supported rule syntax schema. Other tools can consume the schema, then.

For projects like falco-project, consuming this schema in JSON format is very useful. The project is currently using a static version of it https://github.com/falcosecurity/falco-playground/blob/main/src/components/Editor/falcoSchema.json

Feature

Make Falco generate the rule syntax schema in JSON format.

Alternatives

Additional context

I've filled this issue under the falco-playground project since we have a live example of what we need. The end goal is to transfer this issue to the falco repository and implement the feature in Falco.

I'm assigning this issue to me, but I need volunteers to help. 🙏
/assign
/help

cc @falcosecurity/core-maintainers @falcosecurity/falco-playground-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Feb 22, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Feb 23, 2024

/remove-lifecycle stale

cc @falcosecurity/falco-maintainers, I really believe we should move that file to the Falco repo. Do you agree?

also, @LucaGuerra, may that file need to be aligned with #2981?

cc @Rohith-Raju

@Rohith-Raju
Copy link
Contributor

@leogr Yes, I agree!!
Maybe we could add an additional flag where Falco outputs the schema in Json format

@leogr
Copy link
Member Author

leogr commented Mar 26, 2024

We are doing a similar thing for Falco config files. I believe it's time to revamp this. I'm transferring the issue to the falco repo.

@leogr leogr transferred this issue from falcosecurity/falco-playground Mar 26, 2024
@leogr
Copy link
Member Author

leogr commented Mar 26, 2024

/kind feature

Proposing
/milestone 0.38.0
cc @falcosecurity/falco-maintainers

If anyone is willing to help, please let me know. 🙏

@poiana poiana added this to the 0.38.0 milestone Mar 26, 2024
@LucaGuerra LucaGuerra modified the milestones: 0.38.0, 0.39.0 May 30, 2024
@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Aug 29, 2024

/remove-lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Sep 6, 2024

Implemented in #3313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants