Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynatrace output - Client cerfification check even if check certificate is disabled #987

Closed
henrikrexed opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@henrikrexed
Copy link

Describe the bug

When using the dynatrace output i discovered in the logs of falcosidekick that it tries to check the certificate even if this option is disbabled.
here is an output on the logs produced:

2024/09/04 09:18:25 [INFO] : Dynatrace - POST OK (204)
2024/09/04 09:18:25 [ERROR] : Dynatrace - open /etc/certs/client/ca.crt: no such file or directory

How to reproduce it

install falco and falcosidekick:
helm install falco
--set driver.kind=modern_ebpf
--set tty=true
--set collectors.kubernetes.enabled=true
--set falco.json_output=true
--set metrics.enabled=true
--set falcosidekick.enabled=true
--set falcosidekick.config.otlp.traces.checkcert=false
--set falcosidekick.config.otlp.traces.endpoint=http://otel-collector.default.svc.cluster.local:4318/v1/traces
--set falcosidekick.config.otlp.traces.minimumpriority=debug
--set falcosidekick.config.otlp.traces.protocol=grpc
--set falcosidekick.config.otlp.traces.synced=true
--set falcosidekick.config.dynatrace.apiurl=$DTURL/api
--set falcosidekick.config.dynatrace.apitoken=$DTTOKEN
--set falcosidekick.config.dynatrace.minimumpriority=debug
--set falcosidekick.config.dynatrace.checkcert=false
--set falcosidekick.webui.enabled=true
--namespace falco --create-namespace falcosecurity/falco

install the ungard application that would produce falco events:

helm repo add bitnami https://charts.bitnami.com/bitnami
helm install unguard-mariadb bitnami/mariadb --version 11.5.7 --set primary.persistence.enabled=false --wait --namespace unguard --create-namespace
helm install unguard oci://ghcr.io/dynatrace-oss/unguard/chart/unguard --wait --namespace unguard --create-namespace

Expected behaviour
the logs sent by falcosidekick should be ingested in dynatrace without validating the certificate.

Environment

  • Falco version: 0.38.2
    helm chart: falco-4.8.1

  • Cloud provider or hardware configuration:

  • Installation method:

Falco installed on a GKE cluster.
Here is the github repo with the instructions for this environment:
https://github.com/isItObservable/falco

@henrikrexed henrikrexed added the kind/bug Something isn't working label Sep 5, 2024
@Issif Issif added this to the 2.30 milestone Sep 5, 2024
@Issif Issif self-assigned this Sep 5, 2024
@Issif
Copy link
Member

Issif commented Sep 5, 2024

Thanks Henrik, I'll take a look in the next days.

@Issif
Copy link
Member

Issif commented Sep 10, 2024

I found the issue, it comes from a mistake in the values.yaml of the helm chart: https://github.com/falcosecurity/charts/blob/4d2da46d13bf580026fcb9286cb017d6c6f749fe/charts/falcosidekick/values.yaml#L168 this value should be empty by default. This issue is generic to all outputs using the http client. I'll create a fix for that.

Edit: PR falcosecurity/charts#736

Issif added a commit to falcosecurity/charts that referenced this issue Sep 10, 2024
poiana pushed a commit to falcosecurity/charts that referenced this issue Sep 11, 2024
@Issif
Copy link
Member

Issif commented Sep 17, 2024

The fix has been merged in the chart.

@Issif Issif closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Falcosidekick 2.x Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants