From 0b53bd728896345d5de1369468fd15f0f4786a80 Mon Sep 17 00:00:00 2001 From: Andrea Terzolo Date: Fri, 6 Dec 2024 16:13:39 +0100 Subject: [PATCH] chore: fix windows build Signed-off-by: Andrea Terzolo Co-authored-by: Federico Di Pierro --- userspace/libscap/engine/savefile/converter/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/userspace/libscap/engine/savefile/converter/CMakeLists.txt b/userspace/libscap/engine/savefile/converter/CMakeLists.txt index 967798ec8b..8c0759ac14 100644 --- a/userspace/libscap/engine/savefile/converter/CMakeLists.txt +++ b/userspace/libscap/engine/savefile/converter/CMakeLists.txt @@ -13,9 +13,9 @@ # the License. # -# Since we have circular dependencies between libscap and the savefile engine, make this library -# always static (directly linked into libscap) -add_library(scap_savefile_converter STATIC converter.cpp table.cpp) +# Using `STATIC` is not enough on Windows builds, so we directly create object files that will be +# included inside `scap_engine_savefile` library +add_library(scap_savefile_converter OBJECT converter.cpp table.cpp) add_dependencies(scap_savefile_converter uthash) target_include_directories(