Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detected resistance variants to the predict.JSON in WDNN pipeline #247

Open
mgro opened this issue Jun 10, 2021 · 2 comments
Open

Add detected resistance variants to the predict.JSON in WDNN pipeline #247

mgro opened this issue Jun 10, 2021 · 2 comments
Assignees

Comments

@mgro
Copy link

mgro commented Jun 10, 2021

@eford8 The variants based on which the WDNN predicts resistance are currently not reported in the JSON predict output. We can add a step to the WDNN predict python script that parses these variants to add to the predict output.

@mahafarhat
Copy link
Member

@mgro can you please review this issue, and post any progress and anything else pending to do

@mahafarhat mahafarhat assigned mgro and unassigned eford8 Sep 20, 2021
@mgro
Copy link
Author

mgro commented Sep 22, 2021

@mahafarhat yes this specific issue can be closed.

Resistance variants can be explored like in the RF pipelines (https://gentb.hms.harvard.edu/predict/9b809c212cd12a0b0b85baafc6cb3183/).

One problem is that as you know the WDNN not only uses the specific SNPs (defined by position, nucleotide/AA change), but also features like 'any SNP or any indel in gid'. This then looks as follows on GenTB:
Screenshot 2021-09-22 at 13 19 56

Maybe we need to add a sentence that if no specific SNP but only a gene locus is specified simply the presence of any mutation in that gene has been used as a feature in WDNN's prediction?

https://gentb.hms.harvard.edu/tb/media/pipeline/files/feature_list_222.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants