Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SpanRecords by reference in Reporter trait #24

Closed
Tracked by #8
andylokandy opened this issue Aug 12, 2024 · 0 comments · Fixed by #25
Closed
Tracked by #8

Pass SpanRecords by reference in Reporter trait #24

andylokandy opened this issue Aug 12, 2024 · 0 comments · Fixed by #25

Comments

@andylokandy
Copy link
Collaborator

Hello,

The Reporter::report gets called with drained objects, but they are converted to a ref slice, which doesn't allow to own the contents of each element.
That would avoid a lot of clones in the implementations, for example you could avoid the clones here.

Thanks.


Originally posted by @dgrr in tikv/minitrace-rust#217

@andylokandy andylokandy changed the title Pass SpanRecords by reference in Reporter trait Pass SpanRecords by reference in Reporter trait Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant