Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@tinyhttp/app Missing from dependencies causes benchmark to fail #313

Closed
2 tasks done
nrayburn-tech opened this issue Oct 31, 2023 · 0 comments · Fixed by #314
Closed
2 tasks done

@tinyhttp/app Missing from dependencies causes benchmark to fail #313

nrayburn-tech opened this issue Oct 31, 2023 · 0 comments · Fixed by #314

Comments

@nrayburn-tech
Copy link
Contributor

nrayburn-tech commented Oct 31, 2023 •
edited
Loading

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.10.2

Plugin version

No response

Node.js version

18.15.0

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

14.0 (23A344)

Description

#304 didn't add @tinyhttp/app to the dependencies, so when trying to run the benchmarks it fails due to the missing package.

CI failure https://github.com/fastify/benchmarks/actions/runs/6686926348/job/18166915878

Steps to Reproduce

npm install && npm run start

Expected Behavior

Benchmarks run without failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add @tinyhttp/app to dependencies for benchmark
1 participant
@nrayburn-tech